Skip to content

libmicrohttpd: remove unused old versions#303805

Merged
wegank merged 1 commit intoNixOS:masterfrom
panicgh:libmicrohttpd-cleanup
Apr 13, 2024
Merged

libmicrohttpd: remove unused old versions#303805
wegank merged 1 commit intoNixOS:masterfrom
panicgh:libmicrohttpd-cleanup

Conversation

@panicgh
Copy link
Contributor

@panicgh panicgh commented Apr 13, 2024

Description of changes

Motivated by @vcunat's comment: #278920 (comment)

There are no build side-effects, because the versions weren't used anymore in nixpkgs.

I would keep the structure for multi-versions for the moment, since there are new releases of libmicrohttpd and the nixpkg should be updated (TODO separate PR).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 13, 2024
@panicgh panicgh added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 13, 2024
@wegank wegank merged commit b432281 into NixOS:master Apr 13, 2024
@panicgh panicgh deleted the libmicrohttpd-cleanup branch April 14, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants